@remotion/studio: Disable resizing media without explicit duration - #9560
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — adds a guard to canResizeTimelineSequenceDuration that disables the right-edge resize handle (and rejects drag targets) for audio/video sequences when durationInFrames lacks an explicit code value override, plus a regression test.
- New
canResizeTimelineSequenceDurationguard — checks thatcodeValueis present foraudio/videotypes; other sequence types always pass when the prop status is'static'. - Wired into
TimelineSequence.tsx—showRightEdgeDragHandlenow usesdurationCanResize(which calls the new guard) instead ofdurationCanUpdate. - Wired into
getTimelineSequenceDurationDragTargets— fetches the per-sequencedurationInFramesprop status and rejects drag targets the same way. - Test coverage — verifies that an audio sequence without an explicit
durationInFrames(codeValue: undefined) is structurally draggable but functionally returnsnullfromgetTimelineSequenceDurationDragTargets.
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
durationInFramesTesting
bun test packages/studio/src/test/timeline-selection.test.tsbun run buildbun run stylecheckCloses #9268