Skip to content

@remotion/studio: Disable resizing media without explicit duration - #9560

Merged
JonnyBurger merged 1 commit into
mainfrom
codex/fix-audio-duration-resize
Jul 24, 2026
Merged

@remotion/studio: Disable resizing media without explicit duration#9560
JonnyBurger merged 1 commit into
mainfrom
codex/fix-audio-duration-resize

Conversation

@JonnyBurger

Copy link
Copy Markdown
Member

Summary

  • hide the right-edge resize handle for audio and video without an explicit durationInFrames
  • reject duration drag targets for the same case to keep pointer handling consistent
  • add regression coverage for audio with an omitted duration

Testing

  • bun test packages/studio/src/test/timeline-selection.test.ts
  • bun run build
  • bun run stylecheck

Closes #9268

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Jul 24, 2026 8:30am
remotion Ready Ready Preview, Comment Jul 24, 2026 8:30am

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — adds a guard to canResizeTimelineSequenceDuration that disables the right-edge resize handle (and rejects drag targets) for audio/video sequences when durationInFrames lacks an explicit code value override, plus a regression test.

  • New canResizeTimelineSequenceDuration guard — checks that codeValue is present for audio/video types; other sequence types always pass when the prop status is 'static'.
  • Wired into TimelineSequence.tsxshowRightEdgeDragHandle now uses durationCanResize (which calls the new guard) instead of durationCanUpdate.
  • Wired into getTimelineSequenceDurationDragTargets — fetches the per-sequence durationInFrames prop status and rejects drag targets the same way.
  • Test coverage — verifies that an audio sequence without an explicit durationInFrames (codeValue: undefined) is structurally draggable but functionally returns null from getTimelineSequenceDurationDragTargets.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@JonnyBurger
JonnyBurger merged commit 996c273 into main Jul 24, 2026
19 checks passed
@JonnyBurger
JonnyBurger deleted the codex/fix-audio-duration-resize branch July 24, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot drag right edge of <Audio>

1 participant