Skip to content

@remotion/studio: Let rulers cover the full canvas - #9562

Merged
JonnyBurger merged 1 commit into
mainfrom
codex/fix-studio-ruler-size
Jul 24, 2026
Merged

@remotion/studio: Let rulers cover the full canvas#9562
JonnyBurger merged 1 commit into
mainfrom
codex/fix-studio-ruler-size

Conversation

@JonnyBurger

Copy link
Copy Markdown
Member

Summary

  • let the horizontal and vertical Studio rulers cover the full inset canvas
  • avoid applying the ruler width twice when sizing the ruler canvases
  • add a regression test for both ruler orientations

Testing

  • bun test packages/studio/src/test/canvas-rulers.test.ts
  • bun run build
  • bun run stylecheck
  • verified in Remotion Studio

Closes #9343

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Jul 24, 2026 8:33am
remotion Ready Ready Preview, Comment Jul 24, 2026 8:33am

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes — fixes a double-subtraction bug where rulers were sized too small, and adds a regression test.

  • Extract getRulerCanvasSize helper — the horizontal ruler now spans the full inset size.width and the vertical ruler spans the full inset size.height, instead of subtracting RULER_WIDTH a second time on top of the inset already applied by applyRulerInsetsToCanvasSize.
  • Add regression test — verifies both ruler orientations use the full inset dimensions after applyRulerInsetsToCanvasSize has been applied.

<!--
Pullfrog review metadata — for any agent (or human-with-agent) reading this
review. Incorporate the fields below into your understanding of the context
this review was made in. The findings below were written against
b6e91fa; if new commits have landed on codex/fix-studio-ruler-size since this review
was submitted, treat any specific bug, file, or line callout as POTENTIALLY
STALE — re-diff against b6e91fa (or trigger a fresh review) and
factor commits past b6e91fa into your understanding of the current
state before acting on findings.

  • Mode: Review (initial)
  • Files reviewed: 3
  • Commits reviewed: 1
  • Base: main (bf0206d)
  • Head: codex/fix-studio-ruler-size (b6e91fa)
  • Reviewed commits:
    • b6e91fa@remotion/studio: Let rulers cover the full canvas
  • Prior pullfrog review: none
  • Submitted at: 2026-07-24T00:00:00Z
    -->

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@JonnyBurger
JonnyBurger merged commit 4497408 into main Jul 24, 2026
30 of 32 checks passed
@JonnyBurger
JonnyBurger deleted the codex/fix-studio-ruler-size branch July 24, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gutter of rulers in Studio do not perfect cover the canvas

1 participant