@remotion/studio: Clamp sidebar width - #9584
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — caps both Studio sidebars at 350px via new pixel-based max-size props on the splitter component, while preserving the existing percentage-based flex model for all other splitters.
SplitterContainer/SplitterContext— addsmaxFlexerSizeandmaxAntiFlexerSize(bothnumber | null) to props, context type, and context defaults.SplitterElement— appliesmaxWidth(vertical orientation) ormaxHeight(horizontal orientation) as CSS from the context's cap value, resolved toundefinedwhennull.SplitterHandle— during drag start, translates pixel caps into flex-fraction bounds (minFlex/maxFlex) usinggetBoundingClientRectdimensions, clampsstartFlexaccordingly, and reuses these computed bounds for the drag-move clamp.TopPanel— wiresMAX_SIDEBAR_WIDTH = 350asmaxFlexerSizeon the left sidebar splitter andmaxAntiFlexerSizeon the right sidebar splitter.EditorContentandTimeline— passnullfor both new props, keeping their existing pure-percentage behavior.
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
bun run buildbun run stylecheckbunx turbo run lint test --filter='@remotion/studio'Closes #9583