remotion: Reject nested HtmlInCanvas before Chrome 152 - #9726
Merged
JonnyBurger merged 1 commit intoJul 27, 2026
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — detects the Chrome major version at render time and throws an actionable error when HtmlInCanvas is nested on Chrome versions below 152, replacing a silent failure with a clear upgrade-or-unnest message.
- Add
getChromeMajorVersion()andMINIMUM_CHROME_VERSION_FOR_NESTED_HTML_IN_CANVASconstant inpackages/core/src/HtmlInCanvas.tsx— extracts the Chrome major version fromnavigator.userAgent, accounting for bothChrome/andHeadlessChrome/prefixes. - Throw early in
HtmlInCanvasContentwhen nested on Chrome < 152 — the check runs before any canvas initialization, so the user gets an immediate, actionable error instead of a hanging render. - Add regression tests for rejection on HeadlessChrome 151 and acceptance on Chrome 152, with proper
userAgentcleanup intry/finallyblocks.
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
JonnyBurger
deleted the
codex/reject-nested-html-in-canvas-before-chrome-152
branch
July 27, 2026 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
HtmlInCanvasis nestedpaintevent that never arrivesTesting
bun run buildbun run stylecheckbun testinpackages/coreRelated: #9399