@remotion/bundler: Remove legacy positional signatures in v5 - #9739
Merged
Conversation
Contributor
There was a problem hiding this comment.
Reviewed changes — gates bundle() and getCompositions() positional overloads behind ENABLE_V5_BREAKING_CHANGES, migrates all internal call sites and docs to the options-object signatures, and adds tests for both v4 and v5 paths.
- Gate positional signatures on
ENABLE_V5_BREAKING_CHANGES—convertBundleArgumentsIntoOptionsandconvertGetCompositionsArgumentsToOptionsnow accept a boolean flag and throw with a migration message when v5 is active and positional args are received. - Rename internal types —
MandatoryLegacyBundleOptions→MandatoryBundleInternalsOptions(the old name remains as a v4-only type alias that resolves toneverunder v5). - Simplify
NewBundleOptions— removes redundantentryPointfield that was shadowed by explicit declarations inMandatoryBundleOptionsandBundleOptions. - Remove
twoslashfrom historical blog code blocks — the old positional signatures would fail typechecking against the v5-gated declaration types. - Migrate all call sites —
@remotion/cli,@remotion/lambdamock,@remotion/example, it-tests, docs render scripts, and template-still now use options-object syntax. - Add tests —
validate-bundle.test.tsand a newget-compositions.test.tscover both v4 (positional still works) and v5 (positional throws) paths.
✅ No new issues found.
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
Member
Author
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
bundle()andgetCompositions()public signatures and runtime validation behindENABLE_V5_BREAKING_CHANGESbundle()return value as the output-directory stringTesting
bun run buildbun run stylecheckbun test packages/bundler/src/test/validate-bundle.test.ts packages/renderer/src/test/get-compositions.test.ts packages/it-tests/src/rendering/get-compositions.test.tsENABLE_V5_BREAKING_CHANGESand verified the generated declarations only expose the options-object signatures@remotion/bundler,@remotion/cli,@remotion/lambda, andtemplate-stillagainst the v5 declarationsCloses #9486
Preview
bundle()getCompositions()renderStill()