Skip to content

Internal: Classify test-only PRs as internal - #9755

Merged
samohovets merged 1 commit into
mainfrom
pr-name-internal-tests
Jul 27, 2026
Merged

Internal: Classify test-only PRs as internal#9755
samohovets merged 1 commit into
mainfrom
pr-name-internal-tests

Conversation

@samohovets

Copy link
Copy Markdown
Member

Summary

  • classify test-only changes by their user-facing impact instead of their package directory
  • use Internal: for package-local test stabilization work that does not change shipped behavior
  • retain package prefixes when implementation changes are accompanied by tests

This avoids package-prefixed titles for internal-only work such as #9661 and #9754.

Verification

  • bunx oxfmt .agents/skills/pr-name/SKILL.md --write
  • bun run build
  • bun run stylecheck
  • git diff --check

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Jul 27, 2026 7:37pm
remotion Ready Ready Preview, Comment Jul 27, 2026 7:37pm

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes — adds guidance to the pr-name skill so that test-only PRs use the Internal: prefix based on user-facing impact rather than package directory.

  • Extend pr-name skill with test-only classification — test-only changes (new tests, test stabilization, snapshots, fixtures) now use Internal: regardless of which package directory the tests live in, with a concrete example and a carve-out for PRs that also contain implementation changes.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@samohovets
samohovets merged commit ba6dd4e into main Jul 27, 2026
17 checks passed
@samohovets
samohovets deleted the pr-name-internal-tests branch July 27, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant