@remotion/renderer: Fix parallel browser downloads - #9882
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — serializes concurrent browser downloads with a file-based lock to prevent corruption when multiple Remotion processes race to download/extract Chrome into the same cache directory.
- Add
browser-download-lock.ts— file-based cross-process lock usingO_EXCL|O_CREAT(wx), with stale lock recovery (process liveness check + 30s mtime threshold), heartbeat every 5s, and token-based ownership verification. - Wrap
downloadBrowserin the lock — acquires the lock before downloading, rechecks whether the browser was installed by a winner while waiting, and releases the lock infinally. - Add integration test — spawns two worker processes competing for the same lock, asserts the second is blocked while the first holds the lock, and verifies cleanup.
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
bun run buildbun run stylecheckbun test packages/renderer/src(343 tests passed)Closes #9875