Skip to content

@remotion/promo-pages: Render homepage videos after hydration - #9893

Merged
JonnyBurger merged 1 commit into
mainfrom
codex/fix-homepage-video-hydration
Jul 29, 2026
Merged

@remotion/promo-pages: Render homepage videos after hydration#9893
JonnyBurger merged 1 commit into
mainfrom
codex/fix-homepage-video-hydration

Conversation

@JonnyBurger

Copy link
Copy Markdown
Member

Summary

  • Defer the six homepage videos until after hydration
  • Keep the existing aspect-ratio containers as SSR placeholders
  • Select the WebM or WebKit MP4 source after mounting

Test plan

  • bun run build
  • bun run stylecheck
  • Verified SSR card markup contains placeholders without video elements
  • Verified client mounting selects WebM normally and MP4 on WebKit

Closes #9727

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Jul 29, 2026 1:37pm
remotion Ready Ready Preview, Comment Jul 29, 2026 1:37pm

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — Defers homepage video rendering from SSR to client hydration by initializing the video source as null and guarding <video> elements behind a truthy src check, preventing hydration mismatches between server and client while preserving layout via existing aspect-square containers.

  • useTransparentVideoSource — initializes src state as null instead of videoSrc, deferring source selection to the useEffect that runs isWebkit() on mount.
  • Three MakeVideos* components — gates <video> rendering on showVideo && src instead of showVideo, so the video element only appears after the client-side effect sets the correct (WebM or MP4) source.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@JonnyBurger
JonnyBurger merged commit ac20dc9 into main Jul 29, 2026
17 checks passed
@JonnyBurger
JonnyBurger deleted the codex/fix-homepage-video-hydration branch July 29, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is a flicker on the homepage sometimes

1 participant