Skip to content

@remotion/studio: Add default editor menu - #9935

Merged
JonnyBurger merged 10 commits into
mainfrom
codex/configure-default-editor-menu
Jul 30, 2026
Merged

@remotion/studio: Add default editor menu#9935
JonnyBurger merged 10 commits into
mainfrom
codex/configure-default-editor-menu

Conversation

@JonnyBurger

@JonnyBurger JonnyBurger commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary

  • add a "Configure default editor..." item to the Remotion menu
  • show only editors detected as installed and preselect the active default
  • persist the selection through Config.setDefaultEditor() and reload Studio
  • validate the selected editor server-side before updating the config file

Test plan

  • bun test packages/studio-server/src/test/default-editor-route.test.ts packages/studio-server/src/test/editor-registry.test.ts packages/studio-server/src/test/update-public-license.test.ts
  • bunx turbo run make --filter='@remotion/studio' --filter='@remotion/studio-server' --filter='@remotion/studio-shared'
  • bunx turbo run lint test --filter='@remotion/studio'
  • bun run build
  • bun run stylecheck

Stack

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview Jul 30, 2026 1:24pm
remotion Ready Ready Preview Jul 30, 2026 1:24pm

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • New API routes: GET /api/default-editor-info returns the current default editor and installed editors; POST /api/update-default-editor validates and persists the selection into remotion.config.ts via AST manipulation
  • New modal: ConfigureDefaultEditorModal with a Combobox listing installed editors and a "No preference" option, following existing modal patterns
  • Menu integration: Conditionally adds "Configure default editor..." to the Remotion menu when Studio is connected, not in read-only mode, and not in browser Studio
  • studio-shared cleanup: Reordered exports alphabetically and corrected BrowserStudioOperations to a type-only export
  • Tests: Unit tests for config-file AST manipulation (append, replace multiline, preserve comments/strings, removal) and a handler test for the null-editor case

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • New API routes: GET /api/default-editor-info returns the current default editor and installed editors; POST /api/update-default-editor validates and persists the selection into remotion.config.ts via AST manipulation
  • New modal: ConfigureDefaultEditorModal with a Combobox listing installed editors and a "No preference" option, following existing modal patterns
  • Menu integration: Conditionally adds "Configure default editor..." to the Remotion menu when Studio is connected, not in read-only mode, and not in browser Studio
  • studio-shared cleanup: Reordered exports alphabetically and corrected BrowserStudioOperations to a type-only export
  • Tests: Unit tests for config-file AST manipulation (append, replace multiline, preserve comments/strings, removal) and a handler test for the null-editor case

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@JonnyBurger
JonnyBurger merged commit 733b26c into main Jul 30, 2026
20 checks passed
@JonnyBurger
JonnyBurger deleted the codex/configure-default-editor-menu branch July 30, 2026 13:39
@JonnyBurger
JonnyBurger restored the codex/configure-default-editor-menu branch July 30, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant