@remotion/cli: Update skills commands - #9940
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
ℹ️ One minor suggestion inline.
Reviewed changes
skills add: added--yesto auto-confirm overwritesskills update: switched fromskills@1.5.20 update remotion-dev/skillstoskills update <explicit-list> --yesfor precise per-skill updates- Test: validates argument forwarding through the real Remotion CLI with a fake
npxshim
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
| const fullArgs = | ||
| subcommand === 'add' | ||
| ? [ | ||
| '--loglevel=error', |
Contributor
There was a problem hiding this comment.
The old code passed -y as an npx flag to suppress the installation confirmation prompt. The new code removes it and puts --yes at the end of the arg list, which is passed to the skills CLI rather than to npx. If skills@1.5.20 is not already cached, npx will prompt interactively. Consider keeping -y in the npx args (before the package name) as a belt-and-suspenders measure alongside the --yes for the skills CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npx remotion skills addoverwrite existing skills without promptingnpx remotion skills updateTest plan
bun test packages/cli/src/test/skills.test.tsbun run buildbun run stylecheckCloses #9938