@remotion/studio: Fix modal stacking above floating sidebars - #9990
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Portals modals above floating sidebars — the
Modalscomponent now renders viaReactDOM.createPortalintogetPortal(currentZIndex + 1), one layer above the editor's base z-index context, ensuring modals sit above floating sidebars (which usegetPortal(currentZIndex)inMobilePanel). - Adds
stackOnHighesttoHigherZIndex— when enabled, the z-index is computed fromMath.max(context.currentIndex, highestContext.highestIndex) + 1rather than justcontext.currentIndex + 1, so a modal always opens above any active floating sidebar, context menu, or other overlay. - Persists floating sidebars on Escape — because the modal's z-index is strictly above the sidebar's, Escape dismisses the modal first, leaving the sidebar intact for the next Escape.
The frozen stackedIndex ref means a sidebar that opens after a modal already exists would share the same z-index level, but this is not reachable in practice — the modal's full-viewport position: fixed overlay captures all pointer events.
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
bun run buildbun run stylecheckbunx turbo run test --filter='@remotion/studio'