validation for bounded range for data time range#9602
Merged
Conversation
begelundmuller
approved these changes
Jun 24, 2026
pjain1
added a commit
that referenced
this pull request
Jun 24, 2026
* validation for bounded range for data time range * minor fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In metrics time range resolver and other places we treat zero time as no data. When rill time like
infis used then returns start as zero time and that gets converted to nil values for all min/max timestamps so disallow such unbonded time ranges when defining static data time ranges.I thought of changing the behaviour but if
minis zero time that means 0001 year in golang, does that even mean anything? alsoMetricsViewTimeRangeAPI converts zero time toniland UI currently does not do queries if min time innil. So we are already assuming at various places that zero time means no data.Checklist: