Ability to disable models in Rill completely

[k-anshul]

closes https://linear.app/rilldata/issue/ENG-1119/ability-to-pause-and-unpause-reconciler#comment-68e95a7d

Checklist:

• Covered by tests
• Ran it and it works as intended
• Reviewed the diff before requesting a review
• Checked for unhandled edge cases
• Linked the issues it closes
• Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
• Intend to cherry-pick into the release branch
• I'm proud of this work!

[nishantmonu51]

to understand the behavior more here - When the model reconcilation is paused, would it still reconcile metrics view and dashboards or get those in error state as the model execution threw error ? I wonder if instead of throwing error, we do a WARN and make the model reconcile no-op and complete with success so that the underlying metrics view reconcile.

I am also if we might be able to use this for cases when a user only wants to make changes to metrics view and not any models ?

[k-anshul]

When the model reconcilation is paused, would it still reconcile metrics view and dashboards or get those in error state as the model execution threw error ?

Depends:

1. If the model is non partition model then it will fail.
2. If the model is partitioned model then only some partitions will fail which does not mark entire model as failed and metrics view will succeed.

I wonder if instead of throwing error, we do a WARN and make the model reconcile no-op and complete with success so that the underlying metrics view reconcile.

That feels like it can have some unintended consequences like model success but no data. If refresh is not set then it will require explicit refresh after unpause.

[nishantmonu51]

is there any other state other than error we can return ? e.g. not_executed ? instead of passing it? so that when its unpaused it executes ?

[k-anshul]

is there any other state other than error we can return ? e.g. not_executed ? instead of passing it? so that when its unpaused it executes ?

@begelundmuller and I discussed on such solutions. The overall impression was that controller is already quite complex but very stable over more than a 1 year and building such solutions adds another layer to that.
Since this is a maintenance only requirement it may be prudent to develop something that introduces minimal changes to that.

1. Customers can be notified in advance for these maintenance windows where dashboards will still work as before but reconciles will stop.
2. Also reconciling metrics views/dashboards when models have not reconciled is not full proof either. It can end up referring to a new column/change that has not been applied to model yet. The dashboards will go down in that case.

[begelundmuller]

so that when its unpaused it executes ?

FYI, when unpaused, it will re-execute immediately. So the "error" is ephemeral for the duration of the pause, it is not a persistent error.

[begelundmuller]

LGTM

[nishantmonu51]

@codex: resolve conflicts and review then

[chatgpt-codex-connector]

Summary

• Resolved the PR branch conflicts by merging the current base commit into work.
• Reviewed the model-disable implementation. The rill.models.disable setting is documented, included in the parser schema, mapped into InstanceConfig, and causes model reconciliation to return "model execution is paused" while enabled. docs/docs/reference/project-files/rill-yaml.mdL147-L149 runtime/parser/schema/rillyaml.schema.yamlL145-L147 runtime/drivers/registry.goL146-L147 runtime/reconcilers/model.goL155-L156
• Created a pull request via make_pr with title: Resolve conflicts for model execution disable setting.

Testing

• ✅ git merge --no-edit c32b652fc2b1ae538ad526caa2872a12e01f17d6
• ⚠️ go test ./runtime/reconcilers ./runtime/parser/schema ./runtime/drivers — blocked because downloading the required Go 1.25.5 toolchain from proxy.golang.org returned 403 Forbidden.
• ⚠️ GOTOOLCHAIN=local go test ./runtime/reconcilers ./runtime/parser/schema ./runtime/drivers — blocked because the local Go version is 1.23.8, while go.mod requires Go >= 1.25.5.

View task →