Better coverage of mul high instructions #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good thing to improve. Alas, the new mulh and mulhsu tests don't seem to pass on spike. |
|
Hi. Yes, you are right. Turns out I had a little too much faith in my own implementation of the multiplication unit. I had a bug which I fixed. |
aswaterman
added a commit
that referenced
this pull request
Apr 13, 2015
Better coverage of mul high instructions
|
Great, thanks for the contribution. |
jaypiper
pushed a commit
to NJU-ProjectN/riscv-tests-am
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My riscv implementation passed both mulh and mulhu without me having implemented signed behaviour in my multiplication unit.