Skip to content

Update docker image#12

Merged
diw-zw merged 3 commits into
rolebasedgroup:mainfrom
diw-zw:0623-workflow
Jun 23, 2026
Merged

Update docker image#12
diw-zw merged 3 commits into
rolebasedgroup:mainfrom
diw-zw:0623-workflow

Conversation

@diw-zw

@diw-zw diw-zw commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

What

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Refactor / chore
  • Documentation
  • Breaking change

Describe how to verify it

Checklist

  • Code builds and tests pass locally (make build-cli, go test ./...)
  • New Go files include the required copyright header
  • Relevant documentation / examples are updated
  • Breaking changes are called out above with migration notes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various default container images to use a new Aliyun registry and bumps their versions to v0.1.0, alongside adding a Docker build guide. The review feedback identifies several inconsistencies where the registry update was missed, specifically in the benchmark dashboard and HuggingFace model downloader code, as well as in multiple documentation files. Additionally, the feedback notes that removing a sed command from the release guide will break the automated version update process for the benchmark tool.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread cmd/llmctl/benchmark/dashboard_cmd.go Outdated
Comment thread pkg/plugin/source/huggingface.go Outdated
Comment thread cmd/llmctl/README.md Outdated
Comment thread cmd/llmctl/README.md Outdated
Comment thread doc/usage/kubectl-rbg-benchmark.md Outdated
Comment thread doc/usage/kubectl-rbg-benchmark.md Outdated
Comment thread doc/release-guide.md
照微 added 2 commits June 23, 2026 15:10
@diw-zw
diw-zw merged commit 0ea9b07 into rolebasedgroup:main Jun 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant