Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

Add joinmarket-webui#9

Closed
theborakompanioni wants to merge 3 commits into
runcitadel:v2from
theborakompanioni:joinmarket-webui
Closed

Add joinmarket-webui#9
theborakompanioni wants to merge 3 commits into
runcitadel:v2from
theborakompanioni:joinmarket-webui

Conversation

@theborakompanioni

@theborakompanioni theborakompanioni commented Feb 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds Jam for JoinMarket v0.0.3.

This is work in progress till umbrel PR gets merged. Umbrel PR is merged, see getumbrel/umbrel#1216

Please verify the approach regarding defaultPassword/APP_SEED.
This is still untested so far. Feedback is desperately needed.

If there is anything to do on our side, or if we can help in any way, please reach out!

@theborakompanioni theborakompanioni mentioned this pull request Feb 21, 2022
Closed
AaronDewes
AaronDewes approved these changes Feb 27, 2022
View reviewed changes

@AaronDewes AaronDewes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll test it on my node soon

@theborakompanioni theborakompanioni marked this pull request as ready for review March 1, 2022 08:39
@theborakompanioni

theborakompanioni commented Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

@AaronDewes I see you have already added apps/jam/app.yml! Nice 💪

How do we proceed from here? : D
Should we take the same texts as used in Umbrel?

@AaronDewes

AaronDewes commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

I think the description we have no is okay, I'll still test the app a bit and then announce it on Twitter.

@AaronDewes

AaronDewes commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

The app seems to be working for me (Didn't send any sats yet, but looks good otherwise

@theborakompanioni

theborakompanioni commented Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

The app seems to be working for me (Didn't send any sats yet, but looks good otherwise

Nice 🚀

I think the description we have no is okay, I'll still test the app a bit and then announce it on Twitter.

Would you please capitalize the letter M in any alternative description - "Joinmarket" -> "JoinMarket"? Sorry for the nitpick.

@AaronDewes

AaronDewes commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

It's fixed now

@theborakompanioni

theborakompanioni commented Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

It's fixed now

One occurrence still there.. "Joinmarket's awesome, man". Sorry to bother you about this..

@AaronDewes AaronDewes closed this Mar 3, 2022
@theborakompanioni theborakompanioni deleted the joinmarket-webui branch March 10, 2022 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@AaronDewes AaronDewes AaronDewes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theborakompanioni @AaronDewes