[WIP] Adding more BTLE PDUs - #2215
Closed
Matheus-Garbelini wants to merge 1 commit into
Closed
Conversation
gpotter2
reviewed
Aug 18, 2019
| if cls is not None: | ||
| raise | ||
| p = conf.raw_layer(s, _internal=1, _underlayer=self) | ||
| self.add_payload(p) |
Member
There was a problem hiding this comment.
This seems to be a duplicate the default func.
Contributor
Author
There was a problem hiding this comment.
Yes, gonna change this by using dissection_done as proposed by @guedou
Member
|
any updates ? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @gpotter2 and @guedou I'm doing this preliminary PR to add more PDUs for BTLE layer and fix some problems I've found for CRC and BTLE_CONNECT_REQ. Keep in mind that this is a way preliminary PR just to sync what changes needs to be done, that's why I didn't even run flake8 and the tests will probably fail as of now.
Here's the summary of new additions, fixes and observations for this PR: