Update GUI, pytorch and the documentation #107
Merged
Merged
Conversation
ajndkr
reviewed
Aug 24, 2023
| - Install cuda 11.8 from [link](https://developer.nvidia.com/cuda-11-8-0-download-archive) | ||
| - Install `cudatoolkit` from `conda`: `conda install cudatoolkit=<cuda_version_no>` (replace `<cuda_version_no>` with the version on your machine) | ||
| - Install `torch` and `torchvision` dependencies: `pip install torch==1.9.0+<cuda_tag> torchvision==0.10.0+<cuda_tag> -f https://download.pytorch.org/whl/torch_stable.html`, where `<cuda_tag>` is the CUDA tag defined by Pytorch. For example, `pip install torch==1.9.0+cu111 torchvision==0.10.0+cu111 -f https://download.pytorch.org/whl/torch_stable.html` for CUDA 11.1. See [here](https://pytorch.org/get-started/previous-versions/) for a list of all available `torch` and `torchvision` versions. | ||
| - Install `torch` and `torchvision` dependencies: `pip install torch==2.0.1+<cuda_tag> torchvision==0.15.2+<cuda_tag> torchaudio==2.0.2 --index-url https://download.pytorch.org/whl/cu118`, where `<cuda_tag>` is the CUDA tag defined by Pytorch. For example, `pip install torch==2.0.1+cu118 torchvision==0.15.2+cu118 torchaudio==2.0.2 --index-url https://download.pytorch.org/whl/cu118` for CUDA 11.8. |
Member
There was a problem hiding this comment.
current users might face issues. why doesn't cu11.1 work?
Contributor
Author
There was a problem hiding this comment.
I updated the repo to the latest version of pytorch. In their documentation, they are using cuda 11.7 or 11.8
Member
There was a problem hiding this comment.
if it's possible to support cu11.1 as well as cu11.7/cu11.8, that would be great.
Contributor
Author
There was a problem hiding this comment.
I tested this PR with torch1.9.0+cu111 and it seemed to be working fine.
But the old users will need to download the new checkpoints again.
Member
There was a problem hiding this comment.
@Ghassen-Chaabouni okay. please update the README accordingly.
ajndkr
approved these changes
Aug 25, 2023
Member
ajndkr
left a comment
There was a problem hiding this comment.
Please update README before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the requirements, the documentation and the GUI
Changelog:
Added:
arcface_models.pyaccording to the new updates in the SimSwp repo so that we can use the latest version of pytorchUpdated:
README.mdrequirements-dev.txt,requirements.txtandsetup.cfgfs_model.py,models.py,option.pyaccording to the new updates in the SimSwp repo so that we can use the latest version of pytorchui.py