Skip to content

Fix turbo morph handling with custom controller names#30

Merged
skryukov merged 4 commits into
skryukov:mainfrom
volition-co:fix-props
Dec 25, 2025
Merged

Fix turbo morph handling with custom controller names#30
skryukov merged 4 commits into
skryukov:mainfrom
volition-co:fix-props

Conversation

@ibrahima

Copy link
Copy Markdown
Contributor

Because each component gets a custom Stimulus controller name, the data attributes need to be adjusted accordingly. Otherwise the props won't change with a turbo morph response.

I also noticed that the documentation in the README shows the incorrect attribute names (non-customized by the component name).

<div data-controller="turbo-mount"
     data-turbo-mount-component-value="HexColorPicker"
     data-turbo-mount-props-value="{&quot;color&quot;:&quot;#034&quot;}"
     class="mb-5">
</div>

I'm not sure what else needs to be done to make this work (minification/etc)? But at least when I add this event handler to my application.js it fixes the issue.

ibrahima and others added 3 commits December 17, 2025 14:54
Because each component gets a custom Stimulus controller name, the data attributes need to be adjusted accordingly.
@ibrahima

Copy link
Copy Markdown
Contributor Author

@skryukov I ran into a bug with turbo-mount, and I think I have a fix, but I'm not sure how to submit it properly (build steps and whatnot). Would appreciate help if you have a chance, thanks!

@ibrahima ibrahima marked this pull request as ready for review December 17, 2025 23:25
@ibrahima

Copy link
Copy Markdown
Contributor Author

The linter failure seems to be a file I didn't touch, maybe it exists on main as well.

@skryukov skryukov merged commit 8a6942b into skryukov:main Dec 25, 2025
5 of 6 checks passed
@skryukov

Copy link
Copy Markdown
Owner

Thanks @ibrahima! Great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants