Fix turbo morph handling with custom controller names#30
Merged
Conversation
Because each component gets a custom Stimulus controller name, the data attributes need to be adjusted accordingly.
Contributor
Author
|
@skryukov I ran into a bug with turbo-mount, and I think I have a fix, but I'm not sure how to submit it properly (build steps and whatnot). Would appreciate help if you have a chance, thanks! |
Contributor
Author
|
The linter failure seems to be a file I didn't touch, maybe it exists on main as well. |
Owner
|
Thanks @ibrahima! Great catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because each component gets a custom Stimulus controller name, the data attributes need to be adjusted accordingly. Otherwise the props won't change with a turbo morph response.
I also noticed that the documentation in the README shows the incorrect attribute names (non-customized by the component name).
I'm not sure what else needs to be done to make this work (minification/etc)? But at least when I add this event handler to my application.js it fixes the issue.