Skip to content

check duplicate keys for yaml (snakeyaml.version update to 2.4)#1318

Merged
radcortez merged 2 commits into
smallrye:mainfrom
fugerit-org:1-check-duplicate-keys-yaml
Feb 17, 2025
Merged

check duplicate keys for yaml (snakeyaml.version update to 2.4)#1318
radcortez merged 2 commits into
smallrye:mainfrom
fugerit-org:1-check-duplicate-keys-yaml

Conversation

@fugerit79

@fugerit79 fugerit79 commented Feb 15, 2025

Copy link
Copy Markdown
Contributor

Hello, first of all thanks for your great work on SmallRye project 😊

With pull request check duplicate keys #1270 I was only able to detect duplicate key in property configuration.

So I worked on SnakeYAML Project and opened a pull request to check duplicate keys in yaml.

This contribution was added in SnakeYAML 2.4.

Basically I propose to :

  • update SnakeYAML version to 2.4
  • add testing for yaml duplication check (just capture and check logging)

What do you think @radcortez ? is it acceptable?

Thanks in advance.

@radcortez

Copy link
Copy Markdown
Member

Sure. Thank you for the PR.

@radcortez radcortez merged commit e15af82 into smallrye:main Feb 17, 2025
@github-actions github-actions Bot added this to the 3.12.1 milestone Feb 17, 2025
@fugerit79 fugerit79 deleted the 1-check-duplicate-keys-yaml branch February 17, 2025 17:50
@fugerit79

Copy link
Copy Markdown
Contributor Author

Thank to you! I hope someday it will downstream to Quarkus 😊

PS: actually the inspiration for this PR came from an real issue had on one application.

@radcortez

Copy link
Copy Markdown
Member

Actually, it is already there: quarkusio/quarkus#46323

@fugerit79

Copy link
Copy Markdown
Contributor Author

Great! Thanks for the information :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enhancement] check duplicate keys

2 participants