Skip to content

refactor: simplify partitionSubset logic in ConcurrentMessageListenerContainer #3987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bandalgomsu
Copy link
Contributor

Refactored the partitionSubset method to reduce nesting and improve readability while preserving original behavior.

@artembilan
Copy link
Member

Commit sha: c08dbd2, Author: 반달곰수, Committer: 반달곰수; Expected "반달곰수 [email protected]", but got "Su Ko [email protected]"

Your Git client has to be configured for a proper author.
We can accept the current contribution, but let's see if you can simplify it for the future!

Thank you

@bandalgomsu bandalgomsu force-pushed the refactor/partition-subset-cleanup branch 3 times, most recently from 2972fd6 to dae5cee Compare June 30, 2025 20:23
@bandalgomsu
Copy link
Contributor Author

bandalgomsu commented Jun 30, 2025

I changed it accordingly !

I will continue to look for ways to simplify things too.

Thanks for your comment :)

@bandalgomsu
Copy link
Contributor Author

Is there anything else I can do about this PR? @artembilan

@artembilan artembilan requested a review from sobychacko July 1, 2025 20:25
@artembilan
Copy link
Member

Is there anything else I can do about this PR?

I don't thinks so.
Just asked @sobychacko for review and merge and he is the project lead.

Sorry for inconvenience, and thank you for contribution!

@bandalgomsu
Copy link
Contributor Author

Thank you for your reply !! 🙂

@bandalgomsu bandalgomsu force-pushed the refactor/partition-subset-cleanup branch from dae5cee to dcaed89 Compare July 1, 2025 20:40
Copy link
Contributor

@sobychacko sobychacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Could you add your name as an @author to the class?

@sobychacko sobychacko added this to the 4.0.0-M3 milestone Jul 3, 2025
@bandalgomsu bandalgomsu force-pushed the refactor/partition-subset-cleanup branch from 02e3183 to b39ca72 Compare July 3, 2025 21:02
@bandalgomsu
Copy link
Contributor Author

bandalgomsu commented Jul 3, 2025

I've added @author to the class Thank you!!

@sobychacko sobychacko merged commit 9380358 into spring-projects:main Jul 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants