Skip to content

Use homebrew formula from homebrew/core#492

Merged
str4d merged 1 commit into
str4d:mainfrom
pavelzw:patch-1
Jul 18, 2024
Merged

Use homebrew formula from homebrew/core#492
str4d merged 1 commit into
str4d:mainfrom
pavelzw:patch-1

Conversation

@pavelzw

@pavelzw pavelzw commented Apr 7, 2024

Copy link
Copy Markdown
Contributor

https://formulae.brew.sh/formula/rage

rage is now available on homebrew-core. Adding a tap_migrations.json should ensure that old installations of rage are directed to the homebrew-core build.

Comment thread tap_migrations.json

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this file work if it lives in main? When @FiloSottile added the equivalent file alongside merging FiloSottile/age#318, it was into an orphan master branch because that is what Homebrew was fetching from in 2021 (despite I believe FiloSottile/age doing its development in main at the time, as I do here). I don't understand enough about Homebrew taps to know whether the same rationale applies here, and whether this actually needs to be in a master branch.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my anecdotal evidence it should work. IIRC I did the same thing with https://github.com/pavelzw/homebrew-pavelzw/blob/main/tap_migrations.json (living on main) and brew managed to read it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the readme in age on master https://github.com/FiloSottile/age/blob/master/README, it seems like age once used master and thus some people's configurations were still using this instead of main. If you used main all along in this project, this should be safe. Otherwise we would probably need to do the same thing...

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll merge this and we'll see what happens.

@str4d str4d merged commit f932445 into str4d:main Jul 18, 2024
@pavelzw pavelzw deleted the patch-1 branch July 19, 2024 05:20
@str4d str4d added this to the rage 0.11.0 milestone Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants