[Build] Require VC++ 2019 redist minimum#2100
Merged
Kryptos-FR merged 1 commit intoJan 11, 2024
Merged
Conversation
Member
Author
|
Confirmed working on a Sandbox (with Stride 4.1).
Minimal install: SDK + running note: Physics sample was modified to include a hull decomposition. |
xen2
approved these changes
Jan 11, 2024
xen2
left a comment
Member
There was a problem hiding this comment.
LGTM
I double checked, the prerequisites installer was already bumped to install only VS2019 (and not VS2013 anymore).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Update the minimum required VC++ redist to 2019.
Description
We were still requiring VC++ 2013 when building a game from Visual Studio. However, the dependency was updated to VC++ 2019 in commits ed09ac0 and 4571b04.
Related Issue
Discussion: #1498
Motivation and Context
Types of changes
Checklist