Skip to content

remove unused class#2128

Merged
Eideren merged 1 commit into
stride3d:masterfrom
NexStandard:remove_unused
Apr 21, 2024
Merged

remove unused class#2128
Eideren merged 1 commit into
stride3d:masterfrom
NexStandard:remove_unused

Conversation

@IXLLEGACYIXL

Copy link
Copy Markdown
Collaborator

PR Details

the class is completely unused and has no effect as its not implemented either

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR

Kryptos-FR commented Jan 26, 2024

Copy link
Copy Markdown
Member

Is it possibly used (or was used) by the shader code (esp. generated) as a placeholder of some kind.

@IXLLEGACYIXL

Copy link
Copy Markdown
Collaborator Author

Is it possibly used (or was used) by the shader code?

it has 0 references and when searching for the class name in the entire project it doesnt appear, how else could i check if it may be in use still?

@Eideren Eideren merged commit 3540261 into stride3d:master Apr 21, 2024
@Eideren

Eideren commented Apr 21, 2024

Copy link
Copy Markdown
Collaborator

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants