fix: #2214 Vulkan uses gl_InstanceIndex and gl_VertexIndex instead of gl_InstanceId and gl_VertexId as the latter are not supported. #2217
Merged
Conversation
… of gl_InstanceId and gl_VertexId
f0e4251 to
97751a7
Compare
Collaborator
|
I'm guessing those are strictly nomenclature changes then ? Thanks ! |
phr00t
pushed a commit
to phr00t/FocusEngine
that referenced
this pull request
Apr 29, 2024
… of gl_InstanceId and gl_VertexId (stride3d#2217) # Conflicts: # sources/shaders/Xenko.Core.Shaders/Convertor/HlslToGlslConvertor.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Vulkan uses gl_InstanceIndex and gl_VertexIndex instead of gl_InstanceId and gl_VertexId as the latter are not supported.
Related Issue
#2214
Motivation and Context
gl_InstanceId and gl_VertexId are removed in https://github.com/KhronosGroup/GLSL/blob/main/extensions/khr/GL_KHR_vulkan_glsl.txt
Types of changes
Checklist