refactor: Nullable and Modernization for Stride.Core.Serialization#2266
Merged
Conversation
added 7 commits
May 22, 2024 03:48
added 7 commits
May 23, 2024 03:09
IXLLEGACYIXL
commented
May 23, 2024
added 2 commits
May 24, 2024 00:57
Collaborator
Author
|
would be ready for review dont know what oldcollection descriptor does to be still required some nullable warnings are still existent but i dont know how to resolve them |
Eideren
reviewed
May 25, 2024
Eideren
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thanks a bunch for your work @IXLLEGACYIXL
Jklawreszuk
suggested changes
May 26, 2024
Jklawreszuk
approved these changes
May 26, 2024
IXLLEGACYIXL
commented
May 26, 2024
Eideren
reviewed
May 27, 2024
Collaborator
Author
|
ran tests and they fail currently, maybe its a compilation issue... lets see.. |
Collaborator
Author
|
WELL sample tests fail but on all branches with latest main, but the descriptor tests and all other engien tests pass so it seems good |
Collaborator
|
Yep, it's good, TC reported 4 failing tests but those are unrelated, see #2296 |
Collaborator
|
Thanks ! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Modernizing Stride.Core.Reflection
Description
Related Issue
#2156
#2155
Removes all [NotNull] annotations and uses the new Nullable
Removes a bug taht System.Collections anyway crash the editor as serializers are missing
Motivation and Context
Types of changes
Checklist