fix: bug pertaining to ReAttach method for PR #2422

[dloe]

PR Details

Test cases inside Stride.Physics.Tests.SendCollisionEndedWhenEntityIsRemovedTest suite started failing after introduction of PR #2422. Further investigation showed that while entities are being setup inside Attach, the ReAttach method could potentially run and cause duplicate entities to be added to simulation, resulting in possible null ref exceptions and in this case, test failures.

Added flag attachInProgress that only allows the ReAttach method to run when Entity has fully competed all Attach behaviors. Still maintains same behavior that was tested and verified in Stride.Physics.Tests.ColliderShapesTest.VerifyColliderShapeSetup.

Related Issue

Original Issue: #1504
Merged PR: #2422

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My change requires a change to the documentation.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have built and run the editor to try this change out.

[Eideren]

Thanks, although this one kind of looks like a band-aid solution, would there not be a way to prevent re-entry in the first place - something like setting up whatever triggers the re-attach at the very last step of attach itself. If you need to make major changes to re-organize how the logic for those functions is structured for that, do go ahead, although I understand if you want to cut this one short

[Eideren]

I'll merge this one in to make sure release doesn't throw in the context mentioned in the PR, and opened a new issue for what I mentioned above.