Fixed getting actual bounds and refresh rate of the output (monitor/display) from GraphicsOutput.CurrentDisplayMode when using Direct3D

[Feralnex]

PR Details

Fix for the bug #2492.

References:

• https://www.gamedev.net/forums/topic/689459-sharpdx-dxgi-trying-to-get-the-current-display-mode/
• Add manifest to templates to be dpi aware MonoGame/MonoGame#5096

Related Issue

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My change requires a change to the documentation.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have built and run the editor to try this change out.

[Feralnex]

@Feralnex please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@dotnet-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

[Eideren]

Looks good, thanks !

[Eideren]

In which case would it throw ? Might be best to still log it, perhaps through a global logger for this class;

private static readonly Logger Log = GlobalLogger.GetLogger(typeof(GraphicsOutput).FullName);

[Feralnex]

It's a good idea, to be honest I don't know exactly in which cases it might throw, I followed the steps taken from FindClosestMatchingDisplayMode in the same file.

[Eideren]

Actually, you might want to change TryFindMatchingDisplayMode and/or the caller to reflect how you changed the method;

stride/sources/engine/Stride.Graphics/Direct3D/GraphicsOutput.Direct3D.cs

Lines 194 to 198 in 256c47b

	private void InitializeCurrentDisplayMode()
	{
	currentDisplayMode = TryFindMatchingDisplayMode(Format.R8G8B8A8_UNorm)
	?? TryFindMatchingDisplayMode(Format.B8G8R8A8_UNorm);
	}

So, TryFindMatchingDisplayMode should return null if the format doesn't match for that logic to work

[Eideren]

Thanks !

[Feralnex]

You're welcome!