fix: TextBlock enters an infinite loop if the given available space is too small to fit even one character.#2598
Merged
Merged
Conversation
…s too small to fit even one character.
Contributor
Author
|
@dotnet-policy-service agree |
Eideren
reviewed
Feb 1, 2025
Eideren
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution. One small note, looks good otherwise !
|
|
||
| // we reached the end of the line. | ||
| if (indexOfLastSpace < 0) // no space in the line | ||
| if (currentLine.Length <= 1 || CalculateTextSize(currentLine).X <= 0) // just one or all empty characters... just go one by one. |
Collaborator
There was a problem hiding this comment.
Couldn't you replace CalculateTextSize(currentLine).X <= 0 with lineCurrentSize <= 0
Contributor
Author
There was a problem hiding this comment.
Sorry for the late reply, had been on a vacation lately. You're right, they are equivalent. I'll clean it up a bit.
It is the same value as lineCurrentSize. Signed-off-by: net2cn <mcopener@gmail.com>
Kryptos-FR
reviewed
Feb 14, 2025
Kryptos-FR
left a comment
Member
There was a problem hiding this comment.
From a quick reading it looks good to me. I'll let other people do another check, if possible.
Collaborator
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
If TextBlock is given an available space that the width is so small to fit in even one character, TextBlock will enter an infinite loop of repeatedly adding and removing the first character, and creating a new line in the wrapped text. This unexpected infinite loop will crash the editor due to a memory leak.
With this PR, the wrapped text will have at least one character (even if the character is zero width) from the original text in each new line.
(Wrap Text option disabled, horizontal overflow)
(Wrap Text option enabled with the fix, horizontal wrapped with vertical overflow. Without this fix the engine will crash eventually given enough time)
Related Issue
Fixes #2514
Types of changes
Checklist