Skip to content

fix: Temporarily disable the resolver UI as there is a dependency issue with Avalonia.#2651

Merged
Eideren merged 1 commit into
stride3d:masterfrom
Kryptos-FR:feature/nuget-resolver-hotfix
Feb 23, 2025
Merged

fix: Temporarily disable the resolver UI as there is a dependency issue with Avalonia.#2651
Eideren merged 1 commit into
stride3d:masterfrom
Kryptos-FR:feature/nuget-resolver-hotfix

Conversation

@Kryptos-FR

Copy link
Copy Markdown
Member

Hotfix : UI nuget resolver doesn't work because it needs Avalonia which requires... running the nuget resolver 🙃

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit e68e4d7 into stride3d:master Feb 23, 2025
@Kryptos-FR Kryptos-FR deleted the feature/nuget-resolver-hotfix branch February 23, 2025 17:16
@Kryptos-FR Kryptos-FR mentioned this pull request Feb 23, 2025
8 tasks
@xen2

xen2 commented Feb 24, 2025

Copy link
Copy Markdown
Member

For reference, here is where .dll can be embedded in the top level package that will do nuget resolving:
https://github.com/stride3d/stride/blob/master/sources/shared/Stride.NuGetResolver.Targets/Stride.NuGetResolver.Targets.projitems#L36
(note: need to check variable StrideNuGetResolverUI is true to embed the necessary Avalonia .dll)

@Kryptos-FR

Copy link
Copy Markdown
Member Author

@xen2 I did't want to embed Avalonia because it has a lot of dependencies, and some are platform-dependent. I found it easier to resolve it.

@xen2

xen2 commented Feb 24, 2025

Copy link
Copy Markdown
Member

Yes I just saw #2653 after writing previous comment.
Agree with you, I wanted to mention about embedding dll not being ideal anyway.
It's an even better way to fix it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants