feat: Multiple IDE's support#2683
Conversation
|
Thanks. I'll review it soon. Others can also comment and/or try it out with different configurations. |
Kryptos-FR
left a comment
There was a problem hiding this comment.
Quick review (incomplete).
| using Stride.Assets; | ||
| using Stride.Graphics; | ||
| using Stride.Core.VisualStudio; | ||
| using Stride.Core.CodeEditor.VisualStudio; |
There was a problem hiding this comment.
Unsure about the namespace CodeEditor. We will likely have an integrated code editor in the new studio. But here it's about supporting third parties. Maybe CodeEditorSupport or CodeEditing, or something else (CodeEditors)?
There was a problem hiding this comment.
Yeah, I also agree that it can be better expressed, naming sometimes is just hard😅
After some longer thought, I think it'd be valid to separate classes into two namespaces:
- Stride.Core.Solution(s) - Contains classes around Solution entity and Solution management
- Stride.Core.CodeEditorSupport - Contains classes related to Code Editor support
Let me know what you think about this change
|
Maybe related to this and an interesting thing to take into account: |
|
Thanks for pointing out, this seems as a good feature in a separate PR 😅 |
|
VS Code is installed on my machine, yet it doesn't show as an option (opening an existing project). Do I need to change some config?
|
|
@Jklawreszuk are you done with this PR? I saw the latest change. If it's ready we can merge it. |
|
@Kryptos-FR Yes, that's the last change that hides cmd window when running vscode. I believe my PR is now ready to merge 😀 |
PR Details
PR offers the choice of opening projects from within GameStudio using two additional and very popular IDEs among .NET developers : Rider and VSCode/VSCodium
Purpose
I also Introduced and move almost all classes from
Stride.Core.VisualStudiointoStride.Core.CodeEditor- The previous namespace contained abstractions around .NET solution file. In fact, the namespace may have implied that 'Solution' is exclusive to Visual Studio only although this is not true - We can also manage them from dotnet cli, Rider or VSCode with Devkit plugin.Other changes worth mentioning are :
(1) moving DefaultIDE into IDEInfo,
(2) Remove unused parameters in IDEInfo and introduce IDEType,
(3) VisualStudioVersions.AvailableInstances are returning value only on Windows
(4) New, neutral open IDE icon I made using Metro UI Icons - if you have a better idea for an icon I'm open for suggestions
Types of changes
Checklist