Skip to content

fix: Bepu, validate Debug.Assert and remove as the logic was mistakenly inverted#2754

Merged
Eideren merged 1 commit into
stride3d:masterfrom
Eideren:bepu_assert
May 3, 2025
Merged

fix: Bepu, validate Debug.Assert and remove as the logic was mistakenly inverted#2754
Eideren merged 1 commit into
stride3d:masterfrom
Eideren:bepu_assert

Conversation

@Eideren

@Eideren Eideren commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

PR Details

That assert is always hit when the buffer provided to the player is smaller than the amount of hits bepu found.
I wrote this nonsense, Debug.Assert(t > storedMax, ... should have been Debug.Assert(t < storedMax from the start since maximumT ensures subsequent hits have the t < maximumT constraint. I was aware of that at the time given the message, I just wrote the comparison the wrong way around.

Removed the assert as I finally had the time to test this proper.

Related Issue

None reported

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit 0264eba into stride3d:master May 3, 2025
@Eideren Eideren deleted the bepu_assert branch May 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant