Skip to content

Address Cargo Deny findings#5180

Merged
tobiemh merged 3 commits into
mainfrom
gerard/cargo-deny
Nov 25, 2024
Merged

Address Cargo Deny findings#5180
tobiemh merged 3 commits into
mainfrom
gerard/cargo-deny

Conversation

@geraname

@geraname geraname commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

Thank you for submitting this pull request. We really appreciate you spending the time to work on SurrealDB. 🚀 🎉

What is the motivation?

To unblock #5170 by ensuring that Cargo Deny succeeds in CI.

What does this change do?

  • Remove or update use of the deprecated fields by Cargo Deny in:
  • Updates rustls to 0.23.18 to address RUSTSEC-2024-0399.
    • This issue does not affect SurrealDB, we do not use rustls::server::Acceptor::accept().
  • Allows the CDDL-1.0 license, which is used by the inferno crate, required by pprof.
    • This needs approval by @tobiemh after legal review.

What is your testing strategy?

Ensure that Cargo Deny passes.

Is this related to any issues?

No.

Does this change need documentation?

No.

Have you read the Contributing Guidelines?

@geraname geraname marked this pull request as ready for review November 25, 2024 14:25
tobiemh
tobiemh previously approved these changes Nov 25, 2024

@emmanuel-keller emmanuel-keller left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmanuel-keller emmanuel-keller added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 25, 2024
@geraname geraname dismissed stale reviews from emmanuel-keller and tobiemh via 1831108 November 25, 2024 16:12
@tobiemh tobiemh enabled auto-merge November 25, 2024 16:23
@tobiemh tobiemh added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 231407e Nov 25, 2024
@tobiemh tobiemh deleted the gerard/cargo-deny branch November 25, 2024 17:03
@rushmorem rushmorem added this to the v2.1.1 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants