Skip to content

fix(sol-loop): prevent reviewer waits from hanging - #9

Open
LydiaTools wants to merge 1 commit into
t3dotgg:mainfrom
LydiaTools:lydia/sol-loop-deadline
Open

LydiaTools wants to merge 1 commit into
t3dotgg:mainfrom
LydiaTools:lydia/sol-loop-deadline

Conversation

@LydiaTools

Copy link
Copy Markdown

Fixes #8.

The current sol-loop instructions start the review asynchronously and wait for a completion notice without a deadline. If a reviewer prints its verdict but keeps running, the parent can remain blocked for hours.

This documentation-only change bounds each wait to 10 minutes, checks the child for an already-produced verdict, cancels and verifies a still-running child before accepting that verdict, caps a review round at 30 minutes, and asks the reviewer to stop after returning its verdict. Silence, timeout, and errors remain non-approval.

Validation: git diff --check passed. No tests were run; only skills/sol-loop/SKILL.md changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sol-loop: async review round has no deadline, so the parent waits forever if Sol never ends its turn

1 participant