Repository navigation
fix(sol-loop): prevent reviewer waits from hanging - #9
Open
LydiaTools wants to merge 1 commit into
Open
LydiaTools wants to merge 1 commit into
LydiaTools wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8.
The current
sol-loopinstructions start the review asynchronously and wait for a completion notice without a deadline. If a reviewer prints its verdict but keeps running, the parent can remain blocked for hours.This documentation-only change bounds each wait to 10 minutes, checks the child for an already-produced verdict, cancels and verifies a still-running child before accepting that verdict, caps a review round at 30 minutes, and asks the reviewer to stop after returning its verdict. Silence, timeout, and errors remain non-approval.
Validation:
git diff --checkpassed. No tests were run; onlyskills/sol-loop/SKILL.mdchanged.