Repository navigation
Fix for autoscale on k8s-1.9+ without breaking manual scaling - #106
Merged
Cryptophobia merged 18 commits intoAug 8, 2019
Merged
Conversation
This reverts commit 1ce3bc5.
This reverts commit b3a741d.
This reverts commit 1ce3bc5.
This reverts commit b3a741d.
This is basically just manually re-applying the reverted changes from teamhephy#86
kingdonb
approved these changes
Jul 30, 2019
kingdonb
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this up! LGTM
ess
reviewed
Aug 1, 2019
This functionality now lives in KubeHTTPClient, so it is unnecessary to mutate the reported k8s API version in the deployment resource.
Refactoring for new KubeHTTPClient.version() behavior
Cryptophobia
force-pushed
the
ess-fix-autoscale-take-2
branch
from
August 6, 2019 16:38
19865cb to
1b22e15
Compare
added 2 commits
August 8, 2019 10:45
Upgrading to apps/v1 requires changes to the way that Scale action is called, and as we haven't understood this change yet, we will depend on the older version of Deployment api to remain available until we do. includes these squashed commits: * WIP: this commit is probably wrong * WIP: this seems more likely to work
* WIP: hardcode extensions/v1beta1 here for now There is no "App.api_version" attribute and I'm not sure where this information should come from * fixup: line was too long for the style guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes care of scheduler init and scaling RBAC permissions temporary fix started by #104. Thank you @ess!
Tested on AWS and GKE.