Skip to content

Ignore pod scheduling errors during deployments - #112

Merged
Cryptophobia merged 1 commit into
teamhephy:masterfrom
engineyard:ignore-pod-scheduling-error
Dec 13, 2019
Merged

Cryptophobia merged 1 commit into
teamhephy:masterfrom
engineyard:ignore-pod-scheduling-error

Conversation

@jfuechsl

Copy link
Copy Markdown
Contributor

Ignore pod scheduling failures if the DEIS_IGNORE_SCHEDULING_FAILURE environment variable is set.

Pod scheduling errors during deployments, especially in autoscaled clusters, are often temporary. That's why we want to be able to ignore them.

Signed-off-by: Johann Fuechsl johann@fuechsl.co

Ignore pod scheduling failures if the `DEIS_IGNORE_SCHEDULING_FAILURE`
environment variable is set.

Signed-off-by: Johann Fuechsl <johann@fuechsl.co>
@jfuechsl

Copy link
Copy Markdown
Contributor Author

Created #113

@Cryptophobia
Cryptophobia self-requested a review December 2, 2019 20:56

@Cryptophobia Cryptophobia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jfuechsl ,

Thank you for the PR. This will be useful environment variable for temporary fixing this problem on autoscaling clusters.

I am ready to approve this. Just one request is to add the new controller ENV variable that can be set in the following documentation: https://docs.teamhephy.com/managing-workflow/tuning-component-settings/#customizing-the-controller

Can you open a PR changing this file: https://github.com/teamhephy/workflow/blob/master/src/managing-workflow/tuning-component-settings.md#customizing-the-controller

That is all and I would be happy to merge in before the new release. 👍

@Cryptophobia

Copy link
Copy Markdown
Member

Although it would be nice to merge both PRs in, I don't need to wait for the other PR to approve this. :) 💯

@Cryptophobia

Copy link
Copy Markdown
Member

Thanks @jfuechsl ! I have merged and will include this in the upcoming minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants