Skip to content

[docs] better 512 px tile size documenation - #157

Merged
nvkelso merged 4 commits into
masterfrom
nvkelso/more-512px-buffered-docs-off-v1.0.0-docs11
Sep 21, 2017
Merged

nvkelso merged 4 commits into
masterfrom
nvkelso/more-512px-buffered-docs-off-v1.0.0-docs11

Conversation

@nvkelso

@nvkelso nvkelso commented Sep 20, 2017 •

Copy link
Copy Markdown
Member

Including specifying 512 and zoom 14 max to fix #156.

Vector tile changes are over in tilezen/vector-datasource#1399.

Like that other PR: This is off the v1.0.0-docs11 branch that happens for docs to be the same as master. This PR should be merged to master before the v2 PR, and then we can just tag master as
v1.0.0-docs12 and releasing as latest will trigger Mapzen docs update.

@nvkelso

nvkelso commented Sep 21, 2017 •

Copy link
Copy Markdown
Member Author

@iandees iandees left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just an extra stray dot on one line.

Comment thread docs/use-service.md Outdated
**Default:**

Including tile size in the path is not required. When not specified the default size of `256` is returned, and Tangram's default `tile_size` of 256 is used.
.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra period here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in bddc3a7.

@rmarianski rmarianski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the extra period @iandees mentioned, LGTM.

@meetar meetar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from a bunch of typos, but I'd be happy to file a PR for those :)

Comment thread docs/use-service.md Outdated

**Buffered 260 and 516 pixel sized tiles offers several benefits:**

- **Less network requests:** The 2 pixel edge buffers limit reduce network requests from 9 to 1. And a single a single 516 request is equivalent to four 260 requests.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might suggest a bit of clarification here: "The 2 pixel edge buffers reduce network requests from 9 to 1, as neighboring tiles no longer need to be sampled."

@nvkelso

nvkelso commented Sep 21, 2017

Copy link
Copy Markdown
Member Author

Thanks all! I've merged Peter's PR and addressed Ian's comment. Merging.

@nvkelso
nvkelso merged commit 78681cb into master Sep 21, 2017
@nvkelso
nvkelso deleted the nvkelso/more-512px-buffered-docs-off-v1.0.0-docs11 branch September 21, 2017 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicate zoom 14 max zoom for 512 and 516 sized tiles

4 participants