Repository navigation
[docs] better 512 px tile size documenation - #157
Merged
nvkelso merged 4 commits intoSep 21, 2017
Merged
Conversation
Member
Author
|
@meetar can you take a look at the buffered is better because section? |
iandees
requested changes
Sep 21, 2017
iandees
left a comment
Member
There was a problem hiding this comment.
Looks good, just an extra stray dot on one line.
| **Default:** | ||
|
|
||
| Including tile size in the path is not required. When not specified the default size of `256` is returned, and Tangram's default `tile_size` of 256 is used. | ||
| . |
rmarianski
approved these changes
Sep 21, 2017
rmarianski
left a comment
Member
There was a problem hiding this comment.
Besides the extra period @iandees mentioned, LGTM.
meetar
approved these changes
Sep 21, 2017
meetar
left a comment
Contributor
There was a problem hiding this comment.
looks good apart from a bunch of typos, but I'd be happy to file a PR for those :)
|
|
||
| **Buffered 260 and 516 pixel sized tiles offers several benefits:** | ||
|
|
||
| - **Less network requests:** The 2 pixel edge buffers limit reduce network requests from 9 to 1. And a single a single 516 request is equivalent to four 260 requests. |
Contributor
There was a problem hiding this comment.
Might suggest a bit of clarification here: "The 2 pixel edge buffers reduce network requests from 9 to 1, as neighboring tiles no longer need to be sampled."
Member
Author
|
Thanks all! I've merged Peter's PR and addressed Ian's comment. Merging. |
nvkelso
deleted the
nvkelso/more-512px-buffered-docs-off-v1.0.0-docs11
branch
September 21, 2017 18:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including specifying 512 and zoom 14 max to fix #156.
Vector tile changes are over in tilezen/vector-datasource#1399.
Like that other PR: This is off the
v1.0.0-docs11branch that happens for docs to be the same as master. This PR should be merged to master before the v2 PR, and then we can just tag master asv1.0.0-docs12and releasing as latest will trigger Mapzen docs update.