Allow components to refer to themselves.#30
Merged
Conversation
Declaring the component name at the top of the let will allow the render body to invoke the component. `declare` for side-effects within a let is ugly, but better than the alternatives: + No way to replace `let` with `letfn` since the render body won't be calling itself. + Putting the `declare` outside of the let would require the macro splicing, which is trickier to understand and requires more syntax
Contributor
Author
|
Note that I wasn't able to test this commit; I don't use boot; I installed it via homebrew: |
tonsky
added a commit
that referenced
this pull request
Jun 14, 2015
Allow components to refer to themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declaring the component name at the top of the let will allow the render
body to invoke the component.
declarefor side-effects within a let is ugly, but better than thealternatives:
letwithletfnsince the render body won't becalling itself.
declareoutside of the let would require the macrosplicing, which is trickier to understand and requires more syntax