chore: add twilio-style ESLint rules#2763
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1905e7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 86 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shleewhite
force-pushed
the
chore/eslint
branch
from
October 21, 2022 22:01
d0dcffd to
0c31ddd
Compare
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1905e7f:
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Contributor
|
Size Change: -5.77 kB (-1%) Total Size: 747 kB
ℹ️ View Unchanged
|
ghost
reviewed
Oct 24, 2022
gloriliale
reviewed
Oct 25, 2022
gloriliale
left a comment
Contributor
There was a problem hiding this comment.
Looked at as much of it as github would load 😆
Thanks for this work, Lee! Just had one or two things that were maybe blocking, mostly a lot of questions 🤓
ghost
reviewed
Oct 26, 2022
| .filter((bg): boolean => color !== bg) | ||
| .filter((bg): boolean => { | ||
| if (combinedOptions.threshold !== null) { | ||
| if (combinedOptions.threshold != null) { |
There was a problem hiding this comment.
🔕 minor: curious about the commit title here. This change prevented a type error? Could I trouble you for a bit of context here! Thank you
Contributor
Author
There was a problem hiding this comment.
I got a type error that the combinedOptions object might be undefined? I had changed the file so I just reverted it back to what it was before.
gloriliale
previously approved these changes
Oct 26, 2022
shleewhite
force-pushed
the
chore/eslint
branch
from
October 27, 2022 22:38
62b0def to
81394b9
Compare
shleewhite
marked this pull request as ready for review
October 27, 2022 23:48
gloriliale
previously approved these changes
Oct 28, 2022
ghost
previously approved these changes
Oct 28, 2022
shleewhite
force-pushed
the
chore/eslint
branch
from
October 28, 2022 18:32
81394b9 to
7ca99c9
Compare
gloriliale
previously approved these changes
Oct 28, 2022
ghost
previously approved these changes
Oct 28, 2022
SiTaggart
previously approved these changes
Oct 28, 2022
TheSisb
previously approved these changes
Oct 28, 2022
loreina
previously approved these changes
Oct 28, 2022
shleewhite
dismissed stale reviews from loreina, TheSisb, SiTaggart, ghost
, and gloriliale
via
October 28, 2022 19:26
1905e7f
SiTaggart
approved these changes
Oct 28, 2022
loreina
approved these changes
Oct 28, 2022
gloriliale
approved these changes
Oct 28, 2022
TheSisb
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
All the new rules
Contributing to Twilio