Skip to content

feat(select): Select, Option, and OptionGroup#399

Merged
andioneto merged 16 commits into
masterfrom
select-component
May 1, 2020
Merged

feat(select): Select, Option, and OptionGroup#399
andioneto merged 16 commits into
masterfrom
select-component

Conversation

@andioneto

@andioneto andioneto commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

PR for <Select />, <Option />, and <OptionGroup />

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Tasks:

  • Create components (styled where appropriate) for: <Select />, <OptionGroup />, and <Option />
  • Create stories with Knobs (titled "Select Options")
  • Create stories showing each render state
  • Complete unit tests

@vercel

vercel Bot commented Apr 17, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/twilio-dsys/paste/a7ra8wa0o
✅ Preview: https://paste-git-select-component.twilio-dsys.now.sh

@andioneto andioneto added the Status: WIP This PR is still a work-in-progress. No need to review. label Apr 17, 2020
@vercel
vercel Bot temporarily deployed to Preview April 21, 2020 23:36 Inactive
Comment thread packages/paste-core/components/form/src/select/Select.tsx Outdated
Comment thread packages/paste-core/components/form/src/select/Select.tsx Outdated
@vercel
vercel Bot temporarily deployed to Preview April 24, 2020 19:52 Inactive
@andioneto

Copy link
Copy Markdown
Contributor Author

FYI @richbachman @SiTaggart here is the source code after my code review with Simon this morning. I plan to start on unit tests next. Thank you! 😸

@vercel
vercel Bot temporarily deployed to Preview April 27, 2020 16:51 Inactive
@vercel
vercel Bot temporarily deployed to Preview April 27, 2020 23:42 Inactive
@github-actions

github-actions Bot commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

Size Change: +2.51 kB (1%)

Total Size: 186 kB

Filename Size Change
packages/paste-core/components/form/dist/index.es.js 8.28 kB +621 B (7%) 🔍
packages/paste-core/components/form/dist/index.js 7.88 kB +624 B (7%) 🔍
packages/paste-core/core-bundle/dist/index.es.js 33.4 kB +633 B (1%)
packages/paste-core/core-bundle/dist/index.js 33.5 kB +629 B (1%)
ℹ️ View Unchanged
Filename Size Change
packages/paste-core/components/alert/dist/index.es.js 2.76 kB 0 B
packages/paste-core/components/alert/dist/index.js 2.37 kB 0 B
packages/paste-core/components/anchor/dist/index.es.js 1.02 kB 0 B
packages/paste-core/components/anchor/dist/index.js 663 B 0 B
packages/paste-core/components/button/dist/index.es.js 3.9 kB 0 B
packages/paste-core/components/button/dist/index.js 3.52 kB 0 B
packages/paste-core/components/card/dist/index.es.js 1.1 kB 0 B
packages/paste-core/components/card/dist/index.js 715 B 0 B
packages/paste-core/components/heading/dist/index.es.js 1.21 kB 0 B
packages/paste-core/components/heading/dist/index.js 817 B 0 B
packages/paste-core/components/list/dist/index.es.js 1.16 kB 0 B
packages/paste-core/components/list/dist/index.js 766 B 0 B
packages/paste-core/components/modal/dist/index.es.js 2.63 kB 0 B
packages/paste-core/components/modal/dist/index.js 2.23 kB 0 B
packages/paste-core/components/paragraph/dist/index.es.js 225 B 0 B
packages/paste-core/components/paragraph/dist/index.js 266 B 0 B
packages/paste-core/components/screen-reader-only/dist/index.es.js 692 B 0 B
packages/paste-core/components/screen-reader-only/dist/index.js 757 B 0 B
packages/paste-core/components/separator/dist/index.es.js 1.12 kB 0 B
packages/paste-core/components/separator/dist/index.js 733 B 0 B
packages/paste-core/components/spinner/dist/index.es.js 1.8 kB 0 B
packages/paste-core/components/spinner/dist/index.js 1.37 kB 0 B
packages/paste-core/components/truncate/dist/index.es.js 649 B 0 B
packages/paste-core/components/truncate/dist/index.js 711 B 0 B
packages/paste-core/components/typography/dist/index.es.js 1.54 kB 0 B
packages/paste-core/components/typography/dist/index.js 1.56 kB 0 B
packages/paste-core/layout/absolute/dist/index.es.js 475 B 0 B
packages/paste-core/layout/absolute/dist/index.js 524 B 0 B
packages/paste-core/layout/aspect-ratio/dist/index.es.js 1.02 kB 0 B
packages/paste-core/layout/aspect-ratio/dist/index.js 647 B 0 B
packages/paste-core/layout/flex/dist/index.es.js 1.81 kB 0 B
packages/paste-core/layout/flex/dist/index.js 1.4 kB 0 B
packages/paste-core/layout/grid/dist/index.es.js 1.64 kB 0 B
packages/paste-core/layout/grid/dist/index.js 1.23 kB 0 B
packages/paste-core/layout/media-object/dist/index.es.js 508 B 0 B
packages/paste-core/layout/media-object/dist/index.js 545 B 0 B
packages/paste-core/primitives/box/dist/index.es.js 2.12 kB 0 B
packages/paste-core/primitives/box/dist/index.js 2.15 kB 0 B
packages/paste-core/primitives/modal-dialog/dist/index.es.js 14.1 kB 0 B
packages/paste-core/primitives/modal-dialog/dist/index.js 14.1 kB 0 B
packages/paste-core/primitives/text/dist/index.es.js 1.61 kB 0 B
packages/paste-core/primitives/text/dist/index.js 1.64 kB 0 B
packages/paste-design-tokens/dist/tokens.common.js 2.41 kB 0 B
packages/paste-design-tokens/dist/tokens.es6.js 2.36 kB 0 B
packages/paste-style-props/dist/index.es.js 1.89 kB 0 B
packages/paste-style-props/dist/index.js 1.92 kB 0 B
packages/paste-theme/dist/index.es.js 6.72 kB 0 B
packages/paste-theme/dist/index.js 6.28 kB 0 B
packages/paste-types/dist/index.es.js 21 B 0 B
packages/paste-types/dist/index.js 34 B 0 B

compressed-size-action

@vercel
vercel Bot temporarily deployed to Preview April 28, 2020 16:36 Inactive
@vercel
vercel Bot temporarily deployed to Preview April 28, 2020 21:45 Inactive
@vercel
vercel Bot requested a deployment to Preview April 30, 2020 22:28 Abandoned
@andioneto
andioneto merged commit 761924e into master May 1, 2020
@andioneto
andioneto deleted the select-component branch May 1, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Components Related to the component library (core) of this system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants