feat(select): Select, Option, and OptionGroup#399
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/twilio-dsys/paste/a7ra8wa0o |
andioneto
force-pushed
the
select-component
branch
from
April 23, 2020 19:04
6285468 to
f806384
Compare
richbachman
reviewed
Apr 23, 2020
richbachman
reviewed
Apr 23, 2020
Contributor
Author
|
FYI @richbachman @SiTaggart here is the source code after my code review with Simon this morning. I plan to start on unit tests next. Thank you! 😸 |
andioneto
force-pushed
the
select-component
branch
from
April 27, 2020 16:51
e53b260 to
151ab8f
Compare
Contributor
|
Size Change: +2.51 kB (1%) Total Size: 186 kB
ℹ️ View Unchanged
|
andioneto
force-pushed
the
select-component
branch
from
April 28, 2020 16:41
2cb68d7 to
ba48235
Compare
andioneto
force-pushed
the
select-component
branch
from
April 30, 2020 19:59
40bf486 to
7b968e2
Compare
andioneto
force-pushed
the
select-component
branch
from
April 30, 2020 20:35
5ec8939 to
5f93017
Compare
SiTaggart
approved these changes
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for
<Select />,<Option />, and<OptionGroup />Contributing to Twilio
Tasks:
<Select />,<OptionGroup />, and<Option />