Skip to content

feat(website): add reset button example to button doc page#407

Merged
richbachman merged 1 commit into
masterfrom
feat/website/unset-example
Apr 28, 2020
Merged

feat(website): add reset button example to button doc page#407
richbachman merged 1 commit into
masterfrom
feat/website/unset-example

Conversation

@richbachman

Copy link
Copy Markdown
Contributor
  • Added unset button example to button doc page

@richbachman richbachman added Status: Pls CR This PR is ready for Code Reviews Area: Doc Site Related to the documentation website labels Apr 24, 2020
@vercel

vercel Bot commented Apr 24, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/twilio-dsys/paste/mpup1lb3j
✅ Preview: https://paste-git-feat-websiteunset-example.twilio-dsys.now.sh

@github-actions

github-actions Bot commented Apr 24, 2020

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 184 kB

ℹ️ View Unchanged
Filename Size Change
packages/paste-core/components/alert/dist/index.es.js 2.76 kB 0 B
packages/paste-core/components/alert/dist/index.js 2.37 kB 0 B
packages/paste-core/components/anchor/dist/index.es.js 1.02 kB 0 B
packages/paste-core/components/anchor/dist/index.js 663 B 0 B
packages/paste-core/components/button/dist/index.es.js 3.78 kB 0 B
packages/paste-core/components/button/dist/index.js 3.84 kB 0 B
packages/paste-core/components/card/dist/index.es.js 1.1 kB 0 B
packages/paste-core/components/card/dist/index.js 715 B 0 B
packages/paste-core/components/form/dist/index.es.js 7.66 kB 0 B
packages/paste-core/components/form/dist/index.js 7.26 kB 0 B
packages/paste-core/components/heading/dist/index.es.js 1.21 kB 0 B
packages/paste-core/components/heading/dist/index.js 817 B 0 B
packages/paste-core/components/list/dist/index.es.js 1.16 kB 0 B
packages/paste-core/components/list/dist/index.js 766 B 0 B
packages/paste-core/components/modal/dist/index.es.js 2.63 kB 0 B
packages/paste-core/components/modal/dist/index.js 2.23 kB 0 B
packages/paste-core/components/paragraph/dist/index.es.js 225 B 0 B
packages/paste-core/components/paragraph/dist/index.js 266 B 0 B
packages/paste-core/components/screen-reader-only/dist/index.es.js 692 B 0 B
packages/paste-core/components/screen-reader-only/dist/index.js 757 B 0 B
packages/paste-core/components/separator/dist/index.es.js 1.12 kB 0 B
packages/paste-core/components/separator/dist/index.js 733 B 0 B
packages/paste-core/components/spinner/dist/index.es.js 1.8 kB 0 B
packages/paste-core/components/spinner/dist/index.js 1.37 kB 0 B
packages/paste-core/components/truncate/dist/index.es.js 649 B 0 B
packages/paste-core/components/truncate/dist/index.js 711 B 0 B
packages/paste-core/components/typography/dist/index.es.js 1.54 kB 0 B
packages/paste-core/components/typography/dist/index.js 1.56 kB 0 B
packages/paste-core/core-bundle/dist/index.es.js 32.8 kB 0 B
packages/paste-core/core-bundle/dist/index.js 33 kB 0 B
packages/paste-core/layout/absolute/dist/index.es.js 475 B 0 B
packages/paste-core/layout/absolute/dist/index.js 524 B 0 B
packages/paste-core/layout/aspect-ratio/dist/index.es.js 1.02 kB 0 B
packages/paste-core/layout/aspect-ratio/dist/index.js 647 B 0 B
packages/paste-core/layout/flex/dist/index.es.js 1.81 kB 0 B
packages/paste-core/layout/flex/dist/index.js 1.4 kB 0 B
packages/paste-core/layout/grid/dist/index.es.js 1.64 kB 0 B
packages/paste-core/layout/grid/dist/index.js 1.23 kB 0 B
packages/paste-core/layout/media-object/dist/index.es.js 508 B 0 B
packages/paste-core/layout/media-object/dist/index.js 545 B 0 B
packages/paste-core/primitives/box/dist/index.es.js 2.12 kB 0 B
packages/paste-core/primitives/box/dist/index.js 2.15 kB 0 B
packages/paste-core/primitives/modal-dialog/dist/index.es.js 14.1 kB 0 B
packages/paste-core/primitives/modal-dialog/dist/index.js 14.1 kB 0 B
packages/paste-core/primitives/text/dist/index.es.js 1.61 kB 0 B
packages/paste-core/primitives/text/dist/index.js 1.64 kB 0 B
packages/paste-design-tokens/dist/tokens.common.js 2.41 kB 0 B
packages/paste-design-tokens/dist/tokens.es6.js 2.36 kB 0 B
packages/paste-style-props/dist/index.es.js 1.89 kB 0 B
packages/paste-style-props/dist/index.js 1.92 kB 0 B
packages/paste-theme/dist/index.es.js 6.72 kB 0 B
packages/paste-theme/dist/index.js 6.28 kB 0 B
packages/paste-types/dist/index.es.js 21 B 0 B
packages/paste-types/dist/index.js 34 B 0 B

compressed-size-action

@SiTaggart SiTaggart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it weird that it's called unset but the variant and size props are reset?

I feel like they should match, but I don't think we should rename the props.

@richbachman

Copy link
Copy Markdown
Contributor Author

@serifluous would you mind weighing in on the "unset" vs "reset"? Thanks.

@serifluous

Copy link
Copy Markdown
Contributor

Can we make the heading "Unset button styles", "Reset button styles" or something similar?

I added the AC in the ticket to not call it "reset button" because that could be confusing/misleading.

@SiTaggart

Copy link
Copy Markdown
Contributor

I'm fine with "Reset button styles", it's just odd to have both props you have to set needing a value of reset but we don't call it that in the docs. But I might be thinking about it too literally.

If you think it's fine as unset, then just ignore me @serifluous @richbachman

@serifluous

Copy link
Copy Markdown
Contributor

Yeah, "Reset button styles" is fine imo, as long as the whole section is clear that we didn't create a button that resets stuff for consumers in their product.

I wasn't in the grooming where "unset" was chosen, so I don't have a strong opinion on using that word.

@richbachman

Copy link
Copy Markdown
Contributor Author

@SiTaggart @serifluous I just pushed up some text edits. Will you both take a look and let me know if you have any changes. Thanks.

@SiTaggart SiTaggart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don’t need to wrap the button in a div, otherwise its good.

I’m assuming the package size diffs are because this branch hasn’t been rebased on master? Or something?

@richbachman richbachman changed the title feat(website): add unset button example to button doc page feat(website): add reset button example to button doc page Apr 28, 2020
@vercel
vercel Bot temporarily deployed to Preview April 28, 2020 15:11 Inactive
@richbachman
richbachman force-pushed the feat/website/unset-example branch from 1f21417 to 569603b Compare April 28, 2020 15:13
@vercel
vercel Bot temporarily deployed to Preview April 28, 2020 15:13 Inactive
@richbachman
richbachman force-pushed the feat/website/unset-example branch from 569603b to cedf6bb Compare April 28, 2020 15:14
@richbachman

Copy link
Copy Markdown
Contributor Author

@SiTaggart rebased with master and package sizes are now unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Doc Site Related to the documentation website Status: Pls CR This PR is ready for Code Reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants