feat(website): add reset button example to button doc page#407
Conversation
richbachman
commented
Apr 24, 2020
- Added unset button example to button doc page
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/twilio-dsys/paste/mpup1lb3j |
|
Size Change: 0 B Total Size: 184 kB ℹ️ View Unchanged
|
SiTaggart
left a comment
There was a problem hiding this comment.
Is it weird that it's called unset but the variant and size props are reset?
I feel like they should match, but I don't think we should rename the props.
|
@serifluous would you mind weighing in on the "unset" vs "reset"? Thanks. |
|
Can we make the heading "Unset button styles", "Reset button styles" or something similar? I added the AC in the ticket to not call it "reset button" because that could be confusing/misleading. |
|
I'm fine with "Reset button styles", it's just odd to have both props you have to set needing a value of If you think it's fine as unset, then just ignore me @serifluous @richbachman |
|
Yeah, "Reset button styles" is fine imo, as long as the whole section is clear that we didn't create a button that resets stuff for consumers in their product. I wasn't in the grooming where "unset" was chosen, so I don't have a strong opinion on using that word. |
|
@SiTaggart @serifluous I just pushed up some text edits. Will you both take a look and let me know if you have any changes. Thanks. |
SiTaggart
left a comment
There was a problem hiding this comment.
You don’t need to wrap the button in a div, otherwise its good.
I’m assuming the package size diffs are because this branch hasn’t been rebased on master? Or something?
1f21417 to
569603b
Compare
569603b to
cedf6bb
Compare
|
@SiTaggart rebased with master and package sizes are now unchanged. |
cedf6bb to
50426b9
Compare