Remove codespell rare dictionary from website spellcheck#341
Open
JaviChulvi wants to merge 1 commit into
Open
Conversation
The rare dictionary maps valid words manger->manager and trough->through, producing false positives on the LVIS class label manger/trough. Removing rare fixes the source rather than adding ignore-list exceptions, while retaining clear, informal, and en-GB_to_en-US checks. Ref: ultralytics#340
Member
|
👋 Hello @JaviChulvi, thank you for submitting a
For more guidance, please refer to our Contributing Guide. This review is automated, and an engineer will assist if needed. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
approved these changes
Jul 18, 2026
UltralyticsAssistant
left a comment
Member
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Clean, minimal workflow-only change. Removing rare from the Codespell built-in dictionaries preserves the existing spellcheck invocation and ignore rules while narrowing the dictionary set as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The daily
Website links and spellcheckworkflow reports valid LVIS class names as spelling errors:manger→managertrough→throughBoth are valid nouns in the LVIS class label
manger/trough(an animal-feeding container) and should not be "corrected".Root cause
The
Check spellingstep in.github/workflows/links.ymlruns codespell with--builtin clear,rare,informal,en-GB_to_en-US. Codespell'sraredictionary explicitly maps both words as likely typos:Verified these two entries exist only in
dictionary_rare.txt, not inclear,informal, oren-GB_to_en-US, so removingrarefixes them at the source with no reappearance from another dictionary.Change
This fixes the source rather than adding individual
--ignore-words-listexceptions, keeping the high-confidenceclear,informal, anden-GB_to_en-USchecks that are appropriate for a Slack-paging daily check.Trade-off
Dropping
rarealso drops its coverage of other genuine-but-uncommon typos. That is the deliberate trade:rareis opt-in precisely because it assumes uncommon-but-valid words are probably typos — the wrong premise for scanning a real technical website full of model names, dataset labels, and ML jargon. For a daily check that pages a human via Slack, noise reduction is the right call.Notes
.github/workflows/links.ymlline 145 is the onlyrareusage in this repo. Theformat.ymlspellcheck delegates to Ultralytics Actions (spelling: true); the same fix there is tracked in Remove codespellraredictionary to avoid modifying valid words actions#823.Closes #340
Ref: Slack thread https://ultralytics-work.slack.com/archives/C01EDRWJ95W/p1784360628239059
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Removes the Codespell
raredictionary from the website spellcheck workflow. 🔤📊 Key Changes
.github/workflows/links.ymlto stop using therareCodespell dictionary.clear,informal, anden-GB_to_en-USdictionaries and existing ignore rules.🎯 Purpose & Impact