Skip to content

CRAWL4_AI_BASE_DIRECTORY should be Path object instead of string#298

Merged
unclecode merged 2 commits into
unclecode:mainfrom
paulokuong:bug_fix
Nov 28, 2024
Merged

CRAWL4_AI_BASE_DIRECTORY should be Path object instead of string#298
unclecode merged 2 commits into
unclecode:mainfrom
paulokuong:bug_fix

Conversation

@paulokuong

@paulokuong paulokuong commented Nov 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. CRAWL4_AI_BASE_DIRECTORY should be Path object instead of string
  2. Black formatting

@unclecode unclecode merged commit cf35cbe into unclecode:main Nov 28, 2024
@unclecode unclecode self-assigned this Nov 28, 2024
@unclecode unclecode added the ✨ Enhancement Improvement on an existing feature label Nov 28, 2024
@unclecode

unclecode commented Nov 28, 2024

Copy link
Copy Markdown
Owner

This merge has done.

lassedrud pushed a commit to lassedrud/crawl4ai that referenced this pull request Feb 21, 2025
@paulokuong
CRAWL4_AI_BASE_DIRECTORY should be Path object instead of string (unc…
d2fbf2a 
…lecode#298)

Thank you so much for your point. Yes, that's correct. I accept your pull request, and I add your name to a contribution list. Thank you again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@unclecode unclecode

Labels

✨ Enhancement Improvement on an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulokuong @unclecode @pkuong