ames, mesa: revert static receive buffer allocation#755
Merged
Conversation
pkova
added a commit
that referenced
this pull request
Jan 11, 2025
I was messing with static udp receive buffer allocation in #754. We decided to revert it in #755, but I missed one `c3_free` in the stun request packet codepath, causing a fairly significant memory leak when `vere-v3.2` was deployed on a galaxy. This restores the old free and plugs the leak. This bug was unreleased and only appeared on `edge` and specifically only on galaxies, it showed up now because I updated the custom binary on `~fen` for unrelated reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A beautiful idea but given that the receive buffer sometimes ends up as the sender buffer in
ames.cand thatuv_udp_try_sendfails a lot with dead flow consolidation turned on we have to revert this.