Spin Hint#771
Merged
Merged
Conversation
mopfel-winrux
commented
Mar 4, 2025
mopfel-winrux
commented
Mar 4, 2025
mopfel-winrux
commented
Mar 6, 2025
mopfel-winrux
commented
Mar 6, 2025
Collaborator
Author
Collaborator
Author
Fang-
reviewed
Mar 7, 2025
Fang-
left a comment
Member
There was a problem hiding this comment.
Some nits and a concern about potential timer doubling.
Co-authored-by: fang <git@fang.io>
joemfb
requested changes
Mar 10, 2025
joemfb
left a comment
Collaborator
There was a problem hiding this comment.
This looks great. I have a few nits about code organization. It'd be great to try it out in term.c at some point. And we should probably add some spin-stack entries for top-level ipc messages (snapshot save, &c).
joemfb
requested changes
Mar 10, 2025
joemfb
reviewed
Mar 13, 2025
joemfb
requested changes
Mar 19, 2025
mopfel-winrux
commented
May 9, 2025
mopfel-winrux
left a comment
Collaborator
Author
There was a problem hiding this comment.
Quick notes from core blitz
joemfb
requested changes
May 9, 2025
joemfb
requested changes
May 16, 2025
joemfb
left a comment
Collaborator
There was a problem hiding this comment.
These changes look good. A couple style nits:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
%spinhint to vere. This hint provides a labeled compute stack in shared memory. It also includes an SSE endpoint located at/~_~/spinwhich will push the current non-empty stack to the SSE endpoint as a comma separated value string. The endpoint is set to sample the spin stack at 10kHz (0.1 ms).To test this:
/~_~/spin(g ~[1 2 3 4 5 6 7 8 9 10])in dojo.