make u3m_stop reachable#967
Merged
Merged
Conversation
Closed
Collaborator
|
No it should be initialized in mars also. I think mars actually initializes it first. |
Contributor
Author
|
@mopfel-winrux thanks, I misread what was going on. The global variable is indeed initialized in mars only. |
00e558f to
5ff199b
Compare
5ff199b to
ff55cd9
Compare
Contributor
Author
|
I initially wanted to have to separate |
pkova
added a commit
that referenced
this pull request
Feb 23, 2026
Spin stack for windows As it turns out it does not depend on #967 if we just accept that we leak file handles - we did it anyway since we did not close `shm_fd` when we could, and it's probably fine. We also don't have to use file-backed mapping if we just use the Windows-native functions instead of trying to reimplement `shm_open` in Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
u3m_stopwas not called on a shutdown because the processes would exit beforeuv_runwould return. This would prevent some cleanup procedures to run.@mopfel-winrux is spin stack only initialized in urth?