Skip to content

Add checkbox on each line in CodeEditor - #1129

Closed
survivant wants to merge 2 commits into
usebruno:mainfrom
survivant:feature/add-checkbox-CodeEditor
Closed

Add checkbox on each line in CodeEditor#1129
survivant wants to merge 2 commits into
usebruno:mainfrom
survivant:feature/add-checkbox-CodeEditor

Conversation

@survivant

Copy link
Copy Markdown
Contributor

Description

Add checkbox in the CodeEditor if the property : checkboxEnabled is passed to the CodeEditor

image

To have them you need to call the CodeEditor like that (the true.. it should be a variable instead in your code.

<CodeEditor
          collection={collection}
          font={get(preferences, 'font.codeFont', 'default')}
          theme={storedTheme}
          onRun={onRun}
          value={formattedData}
          mode={mode}
          readOnly
          checkboxEnabled={true}
        />

This PR is 1 of 3 to cover a more robust solution with those features implemented.
-#1125
-#1126
-#1127

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@survivant

Copy link
Copy Markdown
Contributor Author

I have a more complete example here : support select all/unselect all, generate tests from checkboxes : https://github.com/survivant/bruno/tree/feature/1125-generate-test-from-response

@helloanoop

Copy link
Copy Markdown
Contributor

Hey @survivant !

Thank you for your contribution. After careful consideration, we've decided that adding checkboxes to each line of the response editor introduces a UX tradeoff that may not be justified by the added functionality of test automation. Additionally, we haven't seen significant interest from the broader community for this feature.

For these reasons, we're going to close this PR.

@helloanoop helloanoop closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants