fix: resolve eager-items selects without explicit valueOptions#9357
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Cover the converter ↔ schema symmetry on the path that actually exercises renderItem: a typed item with a custom ItemLabelGenerator, not a String item that collapses to toString(). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ugur-vaadin
reviewed
May 27, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
ugur-vaadin
approved these changes
May 27, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-beta2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setItems(...)ComboBox/Select/RadioButtonGroup/CheckboxGroup/MultiSelectComboBox was unwritable fromfill_formunless the app also calledFormAIController.valueOptions(...), even though the schema already surfaces those items asenum.renderItemfor both single- and multi-select, so both halves of the tool protocol agree on the label set without forcing a second registration.🤖 Generated with Claude Code