feat: add Breadcrumbs TestBench element classes#9530
Merged
Conversation
web-padawan
commented
Jun 16, 2026
web-padawan
force-pushed
the
feat/breadcrumbs-task8
branch
from
June 16, 2026 13:44
ca19d9c to
0c5a200
Compare
web-padawan
commented
Jun 16, 2026
web-padawan
force-pushed
the
feat/breadcrumbs-task8
branch
3 times, most recently
from
June 16, 2026 14:09
1a80eb9 to
4a9472d
Compare
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Use $("*").withAttribute("slot", "prefix") for the prefix lookup, and
drop the public getOverflowOverlay() — the overlay is an implementation
detail, so openOverflowOverlay() now waits on the collapsed items.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
web-padawan
force-pushed
the
feat/breadcrumbs-task8
branch
from
June 17, 2026 08:24
4a9472d to
14de4ae
Compare
- Drop the overflow API (hasOverflow, getOverflowButton, openOverflowOverlay, getOverflowItems); item retrieval works regardless of whether items overflow. - Replace the click() override with navigate(), which throws when the item has no link, matching SideNavItemElement. - Rename getPrefixSlotContent() to getPrefixComponent() and use single(). - Drop shadow/slot wording from javadocs. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Align with ButtonElement: use getPropertyString("textContent") instead
of resolving the unnamed slot's assigned nodes with JavaScript.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
sissbruecker
approved these changes
Jun 17, 2026
| throw new NoSuchElementException("Item does not contain an anchor", | ||
| e); | ||
| } | ||
| // click() on elements in shadow DOM does not work with Chrome driver |
Contributor
There was a problem hiding this comment.
Small nit: From my testing this also makes clicking items that are in the overflow overlay work, even though they are not be visible on the page when the overflow is not opened. Could extend the comment to include that bit.
Member
Author
There was a problem hiding this comment.
Thanks, updated the comment accordingly.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
|
sissbruecker
pushed a commit
that referenced
this pull request
Jun 17, 2026
…9540) This PR cherry-picks changes from the original PR #9530 to branch 25.2. --- #### Original PR description > ## Description > > Task 8 of the Breadcrumbs SDD. > > Added TestBench element classes. > > ## Type of change > > - Feature > > ## Note > > The first commit is intentionally fully generated by Claude without any modifications on my part. > > It contains questionable APIs like `getOverflowOverlay()`. I will fix any suggestions in follow up commits. Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task 8 of the Breadcrumbs SDD.
Added TestBench element classes.
Type of change
Note
The first commit is intentionally fully generated by Claude without any modifications on my part.
It contains questionable APIs like
getOverflowOverlay(). I will fix any suggestions in follow up commits.