docs: update breadcrumbs spec to list all variants, reorder tasks, fix i18n#11912
Merged
web-padawan merged 3 commits intoJun 11, 2026
Merged
Conversation
This was referenced Jun 10, 2026
Merged
Merged
vursen
approved these changes
Jun 11, 2026
Expose the web component's theme="slash" separator variant through the Flow wrapper, align the i18n setter with the theming guidelines, and reorder the Flow tasks so the work that needs no unreleased Flow core API can land first. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add a "Defined in" column and the primary (Lumo) and accent (Aura) variants to the theme table, cross-referencing the --vaadin-breadcrumbs-link-color Discussion entry for the rationale. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The theme="primary" (Lumo) and theme="accent" (Aura) variants ship in web-components on main, so BreadcrumbsVariant carries LUMO_PRIMARY and AURA_ACCENT as real values alongside SLASH instead of documenting them as planned. Updates the enum, token table, KDD, Discussion, the Flow API doc, and Task 3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
web-padawan
force-pushed
the
docs/breadcrumbs-flow-spec-theme-variants-i18n
branch
from
June 11, 2026 07:15
aea2746 to
d82f16e
Compare
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-beta3. |
ZheSun88
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Jun 17, 2026
…9470) ## Description Task 3 of the Breadcrumbs SDD - based on tasks reorder in vaadin/web-components#11912. Added `BreadcrumbsVariant` enum with `"slash"` variant and `HasThemeVariant<BreadcrumbsVariant>`. ## Type of change - Feature Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
ZheSun88
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Jun 17, 2026
## Description Task 4 of the Breadcrumbs SDD - based on tasks reorder in vaadin/web-components#11912. Added `BreadcrumbsI18n` and `setI18n()` API for setting it reflecting the web component `i18n` property. ## Type of change - Feature Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
ZheSun88
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Jun 17, 2026
#9483) ## Description Fixes #9481 Task 5 of the Breadcrumbs SDD - based on tasks reorder in vaadin/web-components#11912. Added `Mode` enum with `ROUTER` and `MANUAL` and logic related to mode switching. ## Type of change - Feature --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
ZheSun88
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Jun 17, 2026
…9485) ## Description Fixes #9482 Depends on #9483 Task 6 of the Breadcrumbs SDD - based on tasks reorder in vaadin/web-components#11912. Added overrides to disallow manual children modifications when using `Mode.ROUTER`. ## Type of change - Feature --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates the breadcrumbs Flow spec against the current flow-components guidelines and reflects the web component's new
theme="slash"separator variant.Breadcrumbsnow implementsHasThemeVariant<BreadcrumbsVariant>withSLASH("slash")(plannedLUMO_PRIMARY/AURA_ACCENT), per guidelines/09-theming.md. Reverses the earlier "no theme variants" decision now that the web component shipstheme="slash".setI18nrejectsnullviaObjects.requireNonNull(guidelines/10-i18n-and-a11y.md) instead of treatingnullas a reset; the unset/defaults state is the pre-setI18nstate.flow-components-bomFlow-version bump moves from Task 1 to Task 6 (the first task needing PR #24186 /@RouteParent/RouteHierarchy), so the guideline-only work can proceed while those APIs are in flight.theme="slash"variant in the separator section.🤖 Generated with Claude Code